Update DSE_6.9_Release_Notes.md #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append new information from a ticket (DSP-24431) that was merged before release but it was not closed.
emerkle826
approved these changes
Nov 19, 2024
tiagomlalves
requested changes
Nov 19, 2024
DSE_6.9_Release_Notes.md
Outdated
| @@ -19,6 +19,7 @@ If you're developing applications, please refer to the [Java Driver documentatio | |||
|
|
|||
| ## 6.9.4 DSE Core | |||
| * Updated the JDK used to build DSE to versions `8u422` and `11.0.24`. (DSP-23997) | |||
| * Changed the MAX_HEAP_SIZE to avoid OOM errors with new Java11 Garbage Collector. The change is done in the following scrips: bin/dse, bin/dsetool, dse-db/bin/nodetool , resources/cassandra/bin/nodetool . (DSP-24431) | |||
There was a problem hiding this comment.
What about?
* Changed the default MAX_HEAP_SIZE in `dse`, `dsetool` `nodetool`, and `nodetool` scripts to avoid OOM errors with new Java 11 Garbage Collector. (DSP-24431)
There was a problem hiding this comment.
I think that will make it harder to understand if it's a typo in > nodetool, and nodetool scripts < or we are referring a two different scripts
There was a problem hiding this comment.
good point! does our packages provide two nodetool scripts? If so, then we should use the paths from the package not from the source code.
remove dse-db/nodetool as it doesn't show up in the package we provide
tiagomlalves
approved these changes
Nov 20, 2024
DSE_6.9_Release_Notes.md
Outdated
| @@ -19,6 +19,7 @@ If you're developing applications, please refer to the [Java Driver documentatio | |||
|
|
|||
| ## 6.9.4 DSE Core | |||
| * Updated the JDK used to build DSE to versions `8u422` and `11.0.24`. (DSP-23997) | |||
| * Changed the MAX_HEAP_SIZE to avoid OOM errors with new Java11 Garbage Collector. The change is done in the following scrips: bin/dse, bin/dsetool, resources/cassandra/bin/nodetool . (DSP-24431) | |||
There was a problem hiding this comment.
We could use markdown formatting for the scripts and have a space between "Java" and "11".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append new information from a ticket (DSP-24431) that was merged before release but it was not closed.
Release Notes Automation
If you name your pull-request as "Product x.y.z Release ...", after merging the
PR, a GitHub Action will automatically create a product version tag "product-x.y.z".
Supported product names are:
Version supports 3 sets or 4 sets of digits.