Fix version number displayed on startup #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-antoniak
requested review from
joao-r-reis,
alicel,
grighetto,
absurdfarce and
weideng1
as code owners
alicel
reviewed
Jun 12, 2024
RELEASE_PROCESS.md
Outdated
| @@ -36,13 +36,12 @@ The result of that workflow is the creation and publishing of a Docker image wit | |||
|
|
|||
| ### Create an official `Release` in GitHub | |||
|
|
|||
| Once the tag has been pushed to the repository and the build has been verified, a `Release` should be created within GitHub matching the tag. This is a manual step that must be completed after the automation. | |||
| Once the tag has been pushed to the repository and the build process completed, new `Release` will be created automatically within GitHub matching the tag. Manual step is required to update release notes. | |||
There was a problem hiding this comment.
Minor rewording to add some missing articles:
Once the tag has been pushed to the repository and the build process completed, new Release will be created... --> Once the tag has been pushed to the repository and the build process completed, a new Release will be created...
Manual step is required to update release notes --> A manual step is required to update the release notes
RELEASE_PROCESS.md
Outdated
| 4. Paste the contents of the `RELEASE_NOTES` relevant to this release into text-area for `Describe the release`. | ||
| 5. Click the `Publish release` button. | ||
| 1. Navigate in a browser to [https://github.com/datastax/zdm-proxy/releases](https://github.com/datastax/zdm-proxy/releases). | ||
| 2. Search for release matching new tag name and edit it. |
There was a problem hiding this comment.
Search for release matching new tag name and edit it. --> Search for the release matching the new tag name and edit it.
RELEASE_PROCESS.md
Outdated
| 5. Click the `Publish release` button. | ||
| 1. Navigate in a browser to [https://github.com/datastax/zdm-proxy/releases](https://github.com/datastax/zdm-proxy/releases). | ||
| 2. Search for release matching new tag name and edit it. | ||
| 3. Paste the contents of the `RELEASE_NOTES` relevant to this release into text-area for `Describe the release`. |
There was a problem hiding this comment.
into text-area--> into the text area
lukasz-antoniak
force-pushed
the
version-fix
branch
from
b6f7573 to
291fbb5
Compare
alicel
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.