120: Support protocol v2 #119
Conversation
lukasz-antoniak
requested review from
joao-r-reis,
alicel,
grighetto,
absurdfarce and
weideng1
as code owners
|
The purpose of the ticket is to support v2, protocol negotiation in the control connection is just a part of it so I suggest modifying the name of the PR. There's another part that is missing here which is modifying the maximum number of stream ids and that part might be more tricky and will require you to deep dive a bit more into the other part of the codebase (cluster connector, client connector, client handler). Modifying the number of stream ids in the control connection is probably not hard and it's on the part of the code that you're already working with so you can start there. But we also need to set the max number of stream ids based on the protocol version on the non control connections too. At the moment there's a config setting for it that defaults to 2048 but with v2 the connection only supports up to 128 stream ids. |
|
Also we should make sure we have tests covering v2 protocol to validate this PR. |
joao-r-reis
changed the title
joao-r-reis
changed the title
|
Also, the stream ids are still left unchanged, we need to override the max stream ids config setting when it's v2 in case it's above what v2 supports. And need a test for it. |
fix #120