Add proxy metric representing failed connection attempts #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-antoniak
requested review from
joao-r-reis,
alicel,
grighetto,
absurdfarce and
weideng1
as code owners
joao-r-reis
approved these changes
Nov 28, 2024
| @@ -196,15 +196,20 @@ func (cc *ClusterConnector) run() { | |||
| func openConnectionToCluster(connInfo *ClusterConnectionInfo, context context.Context, connectorType ClusterConnectorType, nodeMetrics *metrics.NodeMetrics) (net.Conn, context.Context, error) { | |||
| clusterType := connInfo.connConfig.GetClusterType() | |||
| log.Infof("[%s] Opening request connection to %v (%v).", connectorType, clusterType, connInfo.endpoint.GetEndpointIdentifier()) | |||
| nodeMetricsInstance, err := GetNodeMetricsByClusterConnector(nodeMetrics, connectorType) | |||
| if err != nil { | |||
| log.Errorf("Failed to track open connection metrics for endpoint %v: %v.", connInfo.endpoint.GetEndpointIdentifier(), err) | |||
There was a problem hiding this comment.
Should probably be a warning
There was a problem hiding this comment.
It was an error, so let us leave it like this for time being.
|
Need to update the grafana dashboard too (I think the file is on the automation repo IIRC) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135.