-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom id prefixes #55
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation wise, I think all looks great. The only bit bugging me is the arg names, validation_prefix
and model_prefix
. I think they are a tad misleading, i.e. they indicate on first reading adding a prefix to the validations IDs, as opposed to setting the name for the validation-esq thing. Getting me on that? I think we could do better. Some ideas:
- changing
validation
andmodel
everywhere tovalidator
andvalidatee
(I had already been thinking about making the names more general thatmodel
etc. given you could the use package outside of data science also, maybe overkill though, probs better names than the one I suggested here also), then arg names could bevalidator_rename
,validatee_rename
validation_rename
,model_rename
rename_validation
,rename_model
validation_entity_rename
,model_entity_rename
(btw I had a few dependency issues installing kotsu on my new mac - don't know if worth updating requirements to try to address? I haven't fully resolved how to make pip-compile happy, just had to manually install stuff).
Yea I just been thinking about that in #53 - maybe we shouldn't be using a compiled ...txt
in dev? People just use whatever in dev, and then we always get the latest versions of deps in the CI.
the naming thing is super difficult... i think "prefix" and "rename" sound like they're altering the actual name of each model likewise "validatee" i think is a bit weird is it a huge problem for sktime that kotsu calls them validators and models? is it a possibility for us to just not name them like that? an alternative that i find slightly less weird wrt naming is doing something like allowing users to set a |
@alex-hh got any further thoughts on this? I wouldn't want to move from "validation" to "benchmarks" - I think "benchmarks" is overloaded, as it could be the process (the validation) or the result. The rest of the ideas I'm open to. |
Addresses #54 by adding kwargs to run
(btw I had a few dependency issues installing kotsu on my new mac - don't know if worth updating requirements to try to address? I haven't fully resolved how to make pip-compile happy, just had to manually install stuff).