Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 14.5.1 #683

Merged
merged 3 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "visyn_core",
"description": "Core repository for datavisyn applications.",
"version": "14.5.0",
"version": "14.5.1",
"author": {
"name": "datavisyn GmbH",
"email": "[email protected]",
Expand Down
42 changes: 30 additions & 12 deletions src/vis/vishooks/hooks/useTransformScale.ts
Original file line number Diff line number Diff line change
@@ -1,36 +1,54 @@
import { useMemo } from 'react';
import { scaleLinear } from 'd3-scale';
import { ZoomTransform as D3ZoomTransform, scaleLinear } from 'd3v7';
import { ZoomTransform } from '../interfaces';
import { rescaleX, rescaleY } from '../transform';
import { sxi, txi, tyi } from '../math/matrix4x4';
import { useDeepMemo } from '../../../hooks/useDeepMemo';

interface UseTransformScaleProps {
domain: number[];
range: number[];
transform?: ZoomTransform;
direction: 'x' | 'y';
transformTarget?: 'domain' | 'range';
}

export function useTransformScale({ domain, range, transform, direction }: UseTransformScaleProps) {
return useMemo(() => {
export function useTransformScale({ domain, range, transform, direction, transformTarget }: UseTransformScaleProps) {
return useDeepMemo(() => {
// Invalid data case
if (!domain || !range) {
return null;
}

const scale = scaleLinear().domain(domain).range(range);

if (transform) {
// Untransformed case
if (!transform) {
return {
base: scale,
scaled: direction === 'x' ? rescaleX(transform, scale) : rescaleY(transform, scale),
scaled: scale,
};
}

return {
base: scale,
scaled: scale,
};
switch (transformTarget ?? (domain.length === 2 ? 'domain' : 'range')) {
case 'domain':
return {
base: scale,
scaled: direction === 'x' ? rescaleX(transform, scale) : rescaleY(transform, scale),
};
case 'range': {
const d3transform = new D3ZoomTransform(transform[sxi]!, transform[txi]!, transform[tyi]!);
const transformedRange =
direction === 'x' ? scale.range().map((value) => d3transform.applyX(value)) : scale.range().map((value) => d3transform.applyY(value));

return {
base: scale,
scaled: scale.range(transformedRange),
};
}
default:
throw new Error('Invalid transform target');
}

// We dont want to compare with range/domain reference, only the primitive values
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [domain?.[0], domain?.[1], range?.[0], range?.[1], transform, direction]);
}, [domain, range, transform, direction, transformTarget]);
}