Reduce severity level to Warning for some rules

davelopez · Jun 22, 2024 · f1222f4 · f1222f4
1 parent a8be7c4
commit f1222f4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/client/tests/e2e/suite/extension.ga.e2e.ts b/client/tests/e2e/suite/extension.ga.e2e.ts
@@ -59,12 +59,12 @@ suite("Native (JSON) Workflows", () => {
         {
           message: "The workflow does not specify a creator.",
           range: new vscode.Range(new vscode.Position(0, 0), new vscode.Position(0, 1)),
-          severity: vscode.DiagnosticSeverity.Error,
+          severity: vscode.DiagnosticSeverity.Warning,
         },
         {
           message: "The workflow does not specify a license.",
           range: new vscode.Range(new vscode.Position(0, 0), new vscode.Position(0, 1)),
-          severity: vscode.DiagnosticSeverity.Error,
+          severity: vscode.DiagnosticSeverity.Warning,
         },
         {
           message: "Missing label in workflow output.",

diff --git a/server/gx-workflow-ls-format2/src/profiles.ts b/server/gx-workflow-ls-format2/src/profiles.ts
@@ -36,7 +36,7 @@ export class GxFormat2IWCValidationProfile extends IWCCommonValidationProfile {
     new RequiredPropertyValidationRule(
       "doc",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow is not documented. Documenting workflows helps users understand the purpose of the workflow."
     ),
     new InputTypeValidationRule(DiagnosticSeverity.Error),

diff --git a/server/gx-workflow-ls-native/src/profiles.ts b/server/gx-workflow-ls-native/src/profiles.ts
@@ -33,7 +33,7 @@ export class NativeIWCValidationProfile extends IWCCommonValidationProfile {
     new RequiredPropertyValidationRule(
       "annotation",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow is not annotated. Annotating workflows helps users understand the purpose of the workflow."
     ),
     new WorkflowOutputLabelValidationRule(DiagnosticSeverity.Error),

diff --git a/server/packages/server-common/src/providers/validation/profiles.ts b/server/packages/server-common/src/providers/validation/profiles.ts
@@ -47,13 +47,13 @@ export class IWCCommonValidationProfile implements ValidationProfile {
     new RequiredPropertyValidationRule(
       "creator",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow does not specify a creator."
     ),
     new RequiredPropertyValidationRule(
       "license",
       true,
-      DiagnosticSeverity.Error,
+      DiagnosticSeverity.Warning,
       "The workflow does not specify a license."
     ),
     // Add more common rules here...