feat: do not display the new graph card before the rest are loaded

davidballester · Apr 18, 2020 · 2138dea · 2138dea
1 parent 7f72c7a
commit 2138dea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/scenes/welcome/welcome.component.js b/src/scenes/welcome/welcome.component.js
@@ -102,6 +102,7 @@ function GraphCards({ show, graphNames, openNewGraph, openGraph, className }) {
 }
 
 function Welcome({ openNewGraph, openGraph, graphNames, openImportGraph, isAuthInitialized, classes }) {
+  const displaySkeletons = !isAuthInitialized || !graphNames;
   return (
     <>
       <CookieDialog />
@@ -131,9 +132,9 @@ function Welcome({ openNewGraph, openGraph, graphNames, openImportGraph, isAuthI
               Import graph
             </Button>
           </div>
-          <SkeletonGraphs show={!isAuthInitialized} className={classes.graphList} />
+          <SkeletonGraphs show={displaySkeletons} className={classes.graphList} />
           <GraphCards
-            show={isAuthInitialized}
+            show={!displaySkeletons}
             graphNames={graphNames}
             openGraph={openGraph}
             openNewGraph={openNewGraph}

diff --git a/src/scenes/welcome/welcome.duck.js b/src/scenes/welcome/welcome.duck.js
@@ -22,7 +22,7 @@ export function readNamesSuccess(names) {
   };
 }
 
-export default function reducer(state = {}, action) {
+export default function reducer(state = null, action) {
   switch (action.type) {
     case GRAPH_CREATE: {
       const { id, name } = action.payload;
@@ -60,7 +60,7 @@ export function getGraphNames(state) {
 
 export const getGraphNamesAsArray = createSelector(
   getGraphNames,
-  (graphNames) => entries(graphNames)
+  (graphNames) => (!!graphNames ? entries(graphNames) : undefined)
 );
 
 export function* doReadGraphNames() {