-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix pipeline #320
ci: fix pipeline #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me maybe an extra eye from @danog ?
Not a super fan of removing platform tests tbh, I see that no one has contributed a mac build for clang 18 to the official llvm repo, but maybe there's some other source that could be used for the binaries? Don't have a Mac, but it seems brew offers a clang 18 build... |
Just added a Adding clang 18 is something I would do in #318. Apple builds itself are not skipped, They just use the builtin clang (same as Windows), which is the better test imo as that better replicates a user trying to build on their system. |
Hey, would like to get this moving again. Imo we should get the ci working again with as few changes as possible and then focus on getting clang 18 support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Fixed ci as discussed in #315
Also had to fix clippy rules that changed and made master fail.