Updates to nano6502 serial driver. Added baudrate selection utility #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added another small fix to the same PR, clearing the RX buffer on open/close to avoid issues when doing several xmodem transfers in a row. |
|
Yup, LGTM. Another thing on the list is a timer, needed for proper delays and timeouts... |
|
Indeed, especially as there is such a large speed difference between the supported platforms. Did you see Ivop's ideas for a timer driver in #140? Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a small delay to the non-blocking serial read to prevent xrecv/xsend from timing out too quickly. I also added a utility to set the baudrate to user area 1.
I agree with your comment on the last PR that we need to figure out a good way to handle more than one UART, and I think that we should also add some configuration options to the uart driver. At least the baud rate would be good to set when opening the port, but maybe also data bits, parity and stop bits even though 8N1 is more or less standard these days.