Fix attr command

[eduardocasino]

I've found a couple of issues with the attr command that prevent it from working properly:

@@ -109,8 +109,6 @@ int main()
     while (r != 0xff)
     {
         DIRE* de = (DIRE*)cpm_default_dma + r;
-        if (de->rc == 0x80)
-            continue;

         if (modify)
         {

I don't really know what the intent was here, but this prevented attr to work with files with size > 16K and also froze in an infinite loop as r was no longer updated.

@@ -122,6 +120,10 @@ int main()

             de->us = dr; /* Convert to an FCB */
             cpm_set_file_attributes((FCB*)de);
+
+            /* cpm_set_file_attributes() resets directory index, so */
+            /* recover index for last file match */
+            cpm_findfirst((FCB*)de);
         }

         cpm_conout((de->f[8] & 0x80) ? 'R' : '-');

cpm_set_file_attributes() calls find_first/find_next, so the directory index ends messed up. If you tried to modifiy the attributes of a file, for example, it looped endlessly re-modifying the same file. Executing a find_first with the last modified file restores the dir index.

[davidgiven]

Thanks --- I think the intention n the first chunk was to skip dirents other than the last one, although the logic's all wrong. I can't immediately find any reference as to whether that's a correct assumption, so let's just update all dirents.

Regarding the second --- yes, that's clearly broken. I do wonder why nobody noticed until now!

Merging. Thanks again!

[eduardocasino]

Seems that was closed without merging?

[davidgiven]

Sorry, must have pushed the wrong button. Actually merging now.