Removed unnecessary signal/slot. Clean up code

davidlamhauge · Mar 13, 2024 · d49ba36 · d49ba36
1 parent 513ef2b
commit d49ba36
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 15 deletions.
diff --git a/app/src/timelinecells.cpp b/app/src/timelinecells.cpp
@@ -1185,7 +1185,6 @@ void TimeLineCells::editCameraLayerProperties(LayerCamera* cameraLayer) const
     cameraLayer->setViewRect(QRect(-dialog.getWidth() / 2, -dialog.getHeight() / 2, dialog.getWidth(), dialog.getHeight()));
     cameraLayer->setAperture(dialog.getAperture());
     cameraLayer->setDistance(dialog.getDistance());
-    emit cameraLayer->settingsChanged(cameraLayer->getDistance(), cameraLayer->getAperture());
     mEditor->view()->forceUpdateViewTransform();
 }
 

diff --git a/core_lib/src/interface/editor.cpp b/core_lib/src/interface/editor.cpp
@@ -95,8 +95,8 @@ bool Editor::init()
 
     makeConnections();
 
-    mIsAutosave = mPreferenceManager->isOn(::AUTO_SAVE);
-    mAutosaveNumber = mPreferenceManager->getInt(::AUTO_SAVE_NUMBER);
+    mIsAutosave = mPreferenceManager->isOn(SETTING::AUTO_SAVE);
+    mAutosaveNumber = mPreferenceManager->getInt(SETTING::AUTO_SAVE_NUMBER);
 
     return true;
 }
@@ -113,7 +113,7 @@ int Editor::fps()
 
 void Editor::setFps(int fps)
 {
-    mPreferenceManager->set(::FPS, fps);
+    mPreferenceManager->set(SETTING::FPS, fps);
     emit fpsChanged(fps);
 }
 

diff --git a/core_lib/src/structure/layerbitmap.cpp b/core_lib/src/structure/layerbitmap.cpp
@@ -59,12 +59,6 @@ QRect LayerBitmap::getFrameBounds(int frame)
     return image->bounds();
 }
 
-void LayerBitmap::updateDistanceNearFar()
-{
-    qreal distance = getDistance();
-    qreal hyperFocalDist = getHyperfocalDistance(50.0f, 2.8f);
-}
-
 void LayerBitmap::loadImageAtFrame(QString path, QPoint topLeft, int frameNumber, qreal opacity)
 {
     BitmapImage* pKeyFrame = new BitmapImage(topLeft, path);

diff --git a/core_lib/src/structure/layerbitmap.h b/core_lib/src/structure/layerbitmap.h
@@ -40,8 +40,6 @@ class LayerBitmap : public Layer
     void repositionFrame(QPoint point, int frame);
     QRect getFrameBounds(int frame);
 
-    void updateDistanceNearFar();
-
 protected:
     Status saveKeyFrameFile(KeyFrame*, QString strPath) override;
     KeyFrame* createKeyFrame(int position) override;

diff --git a/core_lib/src/structure/layercamera.h b/core_lib/src/structure/layercamera.h
@@ -74,9 +74,6 @@ class LayerCamera : public Layer
     void setDistance(qreal dist) { mDistance = dist; }
     qreal getDistance() { return mDistance; }
 
-signals:
-    void settingsChanged(qreal mDistance, qreal mAperture);
-
 protected:
     Status saveKeyFrameFile(KeyFrame*, QString path) override;
     KeyFrame* createKeyFrame(int position) override;