feat: add support for Angular v18 (#604)

davidlj95 · May 23, 2024 · 918aaa9 · 918aaa9
1 parent bbb241c
commit 918aaa9
Show file tree

Hide file tree

Showing 14 changed files with 33 additions and 24 deletions.
diff --git a/.github/workflows/pull-request-completed.yml b/.github/workflows/pull-request-completed.yml
@@ -29,7 +29,7 @@ jobs:
     timeout-minutes: 5
     strategy:
       matrix:
-        app_name: [v15, v16, v17]
+        app_name: [v15, v16, v17, v18]
     steps:
       - name: Download bundle size analysis results
         uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4

diff --git a/.github/workflows/reusable-bundle-size.yml b/.github/workflows/reusable-bundle-size.yml
@@ -33,7 +33,7 @@ jobs:
     timeout-minutes: 5
     strategy:
       matrix:
-        app_name: [v15, v16, v17]
+        app_name: [v15, v16, v17, v18]
     env:
       EXAMPLE_APP_DIR: projects/ngx-meta/example-apps/apps/${{ matrix.app_name }}
       OUTPUT_DIR: out/${{ matrix.app_name }}
@@ -111,7 +111,7 @@ jobs:
     timeout-minutes: 5
     strategy:
       matrix:
-        app_name: [v15, v16, v17]
+        app_name: [v15, v16, v17, v18]
     steps:
       - name: Download main bundle analysis results
         uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4

diff --git a/.github/workflows/reusable-e2e.yml b/.github/workflows/reusable-e2e.yml
@@ -22,7 +22,7 @@ jobs:
     timeout-minutes: 5
     strategy:
       matrix:
-        app_name: [v15, v16, v17]
+        app_name: [v15, v16, v17, v18]
     env:
       EXAMPLE_APP_DIR: projects/ngx-meta/example-apps/apps/${{ matrix.app_name }}
     defaults:

diff --git a/.github/workflows/reusable-example-apps.yml b/.github/workflows/reusable-example-apps.yml
@@ -24,7 +24,7 @@ jobs:
     timeout-minutes: 5
     strategy:
       matrix:
-        app_name: [v15, v16, v17]
+        app_name: [v15, v16, v17, v18]
     env:
       EXAMPLE_APP_DIR: projects/ngx-meta/example-apps/apps/${{ matrix.app_name }}
     defaults:

diff --git a/...ions/ngx_meta_bundle_size_v17__report.xml → ...ions/ngx_meta_bundle_size_v18__report.xml b/...ions/ngx_meta_bundle_size_v17__report.xml → ...ions/ngx_meta_bundle_size_v18__report.xml
diff --git a/...ample_apps_v17__build___compare_sizes.xml → ...ample_apps_v18__build___compare_sizes.xml b/...ample_apps_v17__build___compare_sizes.xml → ...ample_apps_v18__build___compare_sizes.xml
diff --git a/..._meta_example_apps_v17__build___serve.xml → ..._meta_example_apps_v18__build___serve.xml b/..._meta_example_apps_v17__build___serve.xml → ..._meta_example_apps_v18__build___serve.xml
diff --git a/..._example_apps_v17__create_example_app.xml → ..._example_apps_v18__create_example_app.xml b/..._example_apps_v17__create_example_app.xml → ..._example_apps_v18__create_example_app.xml
diff --git a/projects/ngx-meta/docs/content/misc/bundle-size.md b/projects/ngx-meta/docs/content/misc/bundle-size.md
@@ -6,6 +6,7 @@ In order to keep library take as few bytes as possible from your app's bundle si
 
 Here's how much bytes the library takes of your main bundle size when using all its features:
 
+--8<-- "includes/bundle-size/v18/bundle-size-report.md"
 --8<-- "includes/bundle-size/v17/bundle-size-report.md"
 --8<-- "includes/bundle-size/v16/bundle-size-report.md"
 --8<-- "includes/bundle-size/v15/bundle-size-report.md"

diff --git a/projects/ngx-meta/docs/content/why/comparison.md b/projects/ngx-meta/docs/content/why/comparison.md
@@ -48,7 +48,7 @@ It is certainly a better option than installing a poorly maintained library. But
 
 | Maintenance                       |        🙋 `ngx-meta`        |      `@avivharuzi/ngx-seo`      |            `@ngaox/seo`             |         `@ngx-meta/core`          |
 | --------------------------------- | :-------------------------: | :-----------------------------: | :---------------------------------: | :-------------------------------: |
-| :simple-angular: versions support | [**v15-v17**][pkg-this][^6] |      [v13-16][pkg-ngx-seo]      |        [v15][pkg-ngaox-seo]         |        [v9][pkg-ngx-meta]         |
+| :simple-angular: versions support | [**v15-v18**][pkg-this][^6] |      [v13-16][pkg-ngx-seo]      |        [v15][pkg-ngaox-seo]         |        [v9][pkg-ngx-meta]         |
 | Documentation                     |             ✅              |               ✅                |                 ✅                  |                ✅                 |
 | Last commit                       |   [![lc-this]][repo-this]   |  [![lc-ngx-seo]][repo-ngx-seo]  |  [![lc-ngaox-seo]][repo-ngaox-seo]  |  [![lc-ngx-meta]][repo-ngx-meta]  |
 | Unit tests                        |  [![ci-b-this]][ci-l-this]  | [![ci-b-ngx-seo]][ci-l-ngx-seo] | [![ci-b-ngaox-seo]][ci-l-ngaox-seo] | [![ci-b-ngx-meta]][ci-l-ngx-meta] |

diff --git a/projects/ngx-meta/docs/content/why/features.md b/projects/ngx-meta/docs/content/why/features.md
@@ -17,7 +17,7 @@ Actually, a series of E2E tests are in place to ensure support for SSR and hydra
 
 ### 🤝 Compatibility with [Angular actively supported versions]
 
-Right now being Angular v15, v16 and v17. Update from an Angular version to another when you're ready. But this library won't be an issue, as latest version will be compatible with all [Angular actively supported versions]. [There are some E2E tests to ensure that indeed][E2E tests]
+Right now being Angular v15, v16, v17 and v18. Update from an Angular version to another when you're ready. But this library won't be an issue, as latest version will be compatible with all [Angular actively supported versions]. [There are some E2E tests to ensure that indeed][E2E tests]
 
 [E2E tests]: https://github.com/davidlj95/ngx/blob/main/.github/workflows/reusable-e2e.yml
 

diff --git a/projects/ngx-meta/example-apps/src/angular-cli-versions.json b/projects/ngx-meta/example-apps/src/angular-cli-versions.json
@@ -9,6 +9,7 @@
   "devDependencies": {
     "v15": "npm:@angular/[email protected]",
     "v16": "npm:@angular/[email protected]",
-    "v17": "npm:@angular/[email protected]"
+    "v17": "npm:@angular/[email protected]",
+    "v18": "npm:@angular/[email protected]"
   }
 }
diff --git a/projects/ngx-meta/example-apps/src/example-app.ts b/projects/ngx-meta/example-apps/src/example-app.ts
@@ -25,6 +25,13 @@ export class ExampleApp {
 }
 
 export const EXAMPLE_APPS = [
+  new ExampleApp({
+    cliVersion: new AngularCliVersion('v18'),
+    cliNewArguments: [
+      '--standalone=true', // Default since v17, but to be explicit
+    ],
+    standalone: true,
+  }),
   new ExampleApp({
     cliVersion: new AngularCliVersion('v17'),
     cliNewArguments: [

diff --git a/projects/ngx-meta/src/package.json b/projects/ngx-meta/src/package.json
@@ -30,9 +30,9 @@
     "tslib": "^2.3.0"
   },
   "peerDependencies": {
-    "@angular/common": "^17 || ^16 || ^15",
-    "@angular/core": "^17 || ^16 || ^15",
-    "@angular/router": "^17 || ^16 || ^15"
+    "@angular/common": "^18 || ^17 || ^16 || ^15",
+    "@angular/core": "^18 || ^17 || ^16 || ^15",
+    "@angular/router": "^18 || ^17 || ^16 || ^15"
   },
   "peerDependenciesMeta": {
     "@angular/router": {