Add dockerfile #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…within a docker container.
Added instructions on how to build and run a docker container that will run Amaxa.
| @@ -335,4 +343,4 @@ Future plans include: | |||
|
|
|||
| ## What Does Amaxa Mean? | |||
|
|
|||
| [ἄμαξα](http://www.perseus.tufts.edu/hopper/text?doc=Perseus%3Atext%3A1999.04.0058%3Aentry%3Da\)%2Fmaca) is the Ancient Greek word for a wagon. | |||
There was a problem hiding this comment.
I think this added a new line, and I struggled with my editor to pull it out.
| @@ -14,6 +14,14 @@ Make sure to invoke within a Python 3.6+ virtual environment or specify Python 3 | |||
|
|
|||
| Amaxa is operating system-agnostic. It has been tested primarily on Linux but is also known to work in a MINGW Windows 7 environment. | |||
|
|
|||
| Using Amaxa within Docker, execute | |||
There was a problem hiding this comment.
I'm fairly new to docker and not sure what level of documentation people expect by including the docker image. The current explanation assumes some knowledge of docker. I'm happy to fill this out with a bit more detail.
|
Thank you for this PR, Brianna! Docker is not my expertise either, so I would like to take some time to study how best to include this within the Amaxa distribution. Please accept my apologies if I take a while to act on the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue with my python 2 versus python 3 locally and tripped down the rabbit hole of pyenv. My solution was to build a docker container with ubuntu and python and thought this might be helpful for other folks using amaxa.
Concerns I have with the current solution:
.gitlab-ci.ymlto run the tests. I haven't run the tests at all as of yet.docker run -it -v amaxa/assets:/amaxa/assets/ amaxa:my_local_amaxa bash