Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for data source name and size blank #564

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for data source name and size blank #564

wants to merge 3 commits into from

Conversation

shreyas-damle
Copy link
Collaborator

  • Fixed data source name missing on Dashboard => Safe Loader => Documents With Findings
    Before:
Screenshot 2024-09-20 at 11 35 38 AM

After:
Screenshot 2024-09-20 at 11 35 16 AM

  • Fixed size empty issue on Dashboard => Safe Loader => Data Source
    Before: blank(-) size
Screenshot 2024-09-20 at 12 28 43 PM

After:
Screenshot 2024-09-20 at 12 28 26 PM

@shreyas-damle
- Fixed data source name missing on Dashboard => Safe Loader => Docum…
6524d38 
…ents With Findings

- Fixed size empty issue on Dashboard => Safe Loader => Data Source
@shreyas-damle
Ruff fix.
ac1e3a2
@shreyas-damle shreyas-damle marked this pull request as ready for review September 20, 2024 09:29
dristysrivastava
dristysrivastava reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@dristysrivastava dristysrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add related UTs

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dristysrivastava dristysrivastava dristysrivastava left review comments

@gr8nishan gr8nishan Awaiting requested review from gr8nishan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyas-damle @dristysrivastava