Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change timezone pst value to pst8pdt #222

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

sensecodevalue
Copy link
Contributor

@sensecodevalue sensecodevalue commented Jun 20, 2024

PR 의 종류는 어떤 것인가요?

  • 버그 수정

수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)

https://fastcampus.atlassian.net/browse/COL-5261

무엇을 어떻게 변경했나요?

코드 변경을 이해하기 위한 배경지식이 필요하다면 설명 해주세요.

PST는 태평양 표준시(Pacific Standard Time)를 의미합니다. 그러나 “PST”는 Intl.DateTimeFormat에서 사용할 수 있는 유효한 IANA 시간대 식별자가 아닙니다.

디펜던시 변경이 있나요?

x

어떻게 테스트 하셨나요?

스모크

코드의 실행결과를 볼 수 있는 로그나 이미지가 있다면 첨부해주세요.

@sensecodevalue sensecodevalue self-assigned this Jun 20, 2024
@sensecodevalue sensecodevalue changed the title fix: change timezone pst value to pst8pdt () fix: change timezone pst value to pst8pdt Jun 20, 2024
@day1-dev-adm day1-dev-adm added the bug Something isn't working label Jun 20, 2024
Copy link
Contributor

@soomtong soomtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@mitrvlr mitrvlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FF image

LGTM!

Copy link

@kevinGwon kevinGwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sensecodevalue sensecodevalue merged commit 5f2c73e into main Jun 20, 2024
1 check passed
@sensecodevalue sensecodevalue deleted the fix/date-util-timezone branch June 20, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants