-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x deprecations (and more) #244
Merged
hibiyasleep
merged 11 commits into
refactor/remove_namespace
from
refactor/4x-deprecations
Feb 19, 2025
Merged
4.x deprecations (and more) #244
hibiyasleep
merged 11 commits into
refactor/remove_namespace
from
refactor/4x-deprecations
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f059fa
to
c97a292
Compare
bc2d600
to
97243e7
Compare
TaehuiKim
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- lint fix로 휘리릭 작성해놓은 커밋 정리 살짝 해줬으면 하는 작은 소망이 있습니다.
f0780be
to
362dd49
Compare
This reverts commit 6cbe3ac.
f4a5427
to
9eb56aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#243 에 머지하는 PR입니다
오래되었거나, 대체하는 기능이 생겼거나, 중복되거나, 쓰이지 않는 method들을 대량 정리합니다
명단
boolean-util /
valueOf
->parseBoolean
안 쓰이는 줄 알았는데 환경변수 해석할 때 꽤 많이 쓰이고 있었습니다… 더 나은 이름으로 갱신합니다
map-util /
get
-> 삭제Map#get과 중복됩니다.
number-util /
valueOfNumber
-> 삭제사용 0건. 대부분 위에 있는 (int)valueOf를 사용하고 있습니다.
object-util /
serialize
,deserialize
-> deprecated겸사겸사 잘못 지정되어 있는 타입을 수정합니다. (JSON.parse는 직렬화될 수 있는 아무 타입이나 리턴할 수 있습니다)
object-util /
isNullish
-> deprecated== null
을 권장합니다.object-util /
deepClone
-> deprecatedstructuredClone
을 권장합니다.string-util /
splitString
,joinStrings
-> deprecated…