Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x deprecations (and more) #244

Merged
merged 11 commits into from
Feb 19, 2025

Conversation

hibiyasleep
Copy link
Contributor

#243 에 머지하는 PR입니다

오래되었거나, 대체하는 기능이 생겼거나, 중복되거나, 쓰이지 않는 method들을 대량 정리합니다

명단

  • boolean-util / valueOf -> parseBoolean
    안 쓰이는 줄 알았는데 환경변수 해석할 때 꽤 많이 쓰이고 있었습니다… 더 나은 이름으로 갱신합니다

  • map-util / get -> 삭제
    Map#get과 중복됩니다.

  • number-util / valueOfNumber -> 삭제
    사용 0건. 대부분 위에 있는 (int)valueOf를 사용하고 있습니다.

  • object-util / serialize, deserialize -> deprecated
    겸사겸사 잘못 지정되어 있는 타입을 수정합니다. (JSON.parse는 직렬화될 수 있는 아무 타입이나 리턴할 수 있습니다)

  • object-util / isNullish -> deprecated
    == null을 권장합니다.

  • object-util / deepClone -> deprecated
    structuredClone을 권장합니다.

  • string-util / splitString, joinStrings -> deprecated

Copy link
Contributor

@TaehuiKim TaehuiKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • lint fix로 휘리릭 작성해놓은 커밋 정리 살짝 해줬으면 하는 작은 소망이 있습니다.

@bohongu bohongu force-pushed the refactor/remove_namespace branch 2 times, most recently from f0780be to 362dd49 Compare February 18, 2025 07:41
@hibiyasleep hibiyasleep force-pushed the refactor/4x-deprecations branch from f4a5427 to 9eb56aa Compare February 19, 2025 04:30
@hibiyasleep hibiyasleep merged commit ec9520e into refactor/remove_namespace Feb 19, 2025
1 check passed
@hibiyasleep hibiyasleep deleted the refactor/4x-deprecations branch February 19, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants