Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check doesn't wait for everything to start #1712

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Philip-21
Copy link
Contributor

Pull Request Title

fix for daytona healthcheck not waiting for all services to start

Description

Ensures Daytona health check functions properly before exiting command

Related Issue(s)

closes #1357

Signed-off-by: Philip-21 <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
@Philip-21 Philip-21 requested a review from a team as a code owner January 14, 2025 10:33
@Philip-21 Philip-21 marked this pull request as draft January 14, 2025 10:34
@Philip-21
Copy link
Contributor Author

Hey @Tpuljak , this pr is still in progress, i decided to follow the review you mentioned here, i just want to know if i am initializing the health of the providers well and i exposed the endpoint properly in the provider controller

Signed-off-by: Philip-21 <[email protected]>
@Tpuljak
Copy link
Member

Tpuljak commented Jan 14, 2025

@Philip-21 it looks to be going in the right direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daytona server start health check doesn't wait for everything to start
2 participants