Merge pull request #201 from rlaiola/datefix

Fix wrong date format crash
dbis-uibk · Jun 27, 2024 · 69808a3 · 69808a3
2 parents b9414f4 + 88c04fa
commit 69808a3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/db/exec/ValueExpr.ts b/src/db/exec/ValueExpr.ts
@@ -386,6 +386,8 @@ export class ValueExprGeneric extends ValueExpr {
 				return true;
 
 			case 'date':
+				// Check wether the date format is valid
+				this._parseIsoDate(this._args[0]._args[0]);
 				return this._checkArgsDataType(schemaA, schemaB, ['string']);
 
 			case 'adddate':

diff --git a/src/db/tests/translate_tests_ra.ts b/src/db/tests/translate_tests_ra.ts
@@ -1073,6 +1073,17 @@ QUnit.test('pi with eval: date', function (assert) {
 	assert.deepEqual(result, reference);
 });
 
+QUnit.test('pi with wrong date format', function (assert) {
+	try {
+		const query = "pi date('01-01-1970')->d (R)";
+		exec_ra(query, getTestRelations());
+		assert.ok(false);
+	}
+	catch (e) {
+		assert.ok(true);
+	}
+});
+
 QUnit.test('pi with eval: upper()', function (assert) {
 	const relations = getTestRelations();
 	const result = exec_ra(" sigma x < 'D' pi upper(S.b)->x S ", relations).getResult();