Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix date check crash #217

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

KPMGE
Copy link

@KPMGE KPMGE commented Oct 16, 2024

The date check, implemented on #201 was causing a crash when a conversion to data was being performed. That happens because when a field of type date is referenced there's no string args to check, which causes an exception trying to access undefined.

In this PR i also fix the ValueExprFunction typescript types. There were missing types related to a new implementation of reverse, replace, repeat, rlike and regexp.

The error was:
image

Now it works:
image

@rlaiola
Copy link
Contributor

rlaiola commented Oct 16, 2024

@KPMGE please double-check if the modification works with the use case in #199

@rlaiola
Copy link
Contributor

rlaiola commented Oct 16, 2024

The date check, implemented on #201 was causing a crash when a conversion to data was being performed. That happens because when a field of type date is referenced there's no string args to check, which causes an exception trying to access undefined.

@KPMGE instead of date(Bdate) please test as well with another string field like Dependent_name, which does not have the required format. I guess that it might generate an exec exception.

In this PR i also fix the ValueExprFunction typescript types. There were missing types related to a new implementation of reverse, replace, repeat, rlike and regexp.

This and other fixes were proposed in #215

@rlaiola
Copy link
Contributor

rlaiola commented Oct 16, 2024

Just to keep track, a few changes have been proposed in KPMGE#21

KPMGE and others added 2 commits October 16, 2024 14:47
Fix date with empty string and handle invalid date format during execution
@KPMGE
Copy link
Author

KPMGE commented Oct 16, 2024

The date check, implemented on #201 was causing a crash when a conversion to data was being performed. That happens because when a field of type date is referenced there's no string args to check, which causes an exception trying to access undefined.

@KPMGE instead of date(Bdate) please test as well with another string field like Dependent_name, which does not have the required format. I guess that it might generate an exec exception.

In this PR i also fix the ValueExprFunction typescript types. There were missing types related to a new implementation of reverse, replace, repeat, rlike and regexp.

This and other fixes were proposed in #215

Thanks for the suggestions @rlaiola

@rlaiola
Copy link
Contributor

rlaiola commented Oct 17, 2024

Tested and everything looks fine. Good to go!

@KPMGE
Copy link
Author

KPMGE commented Oct 17, 2024

Tested and everything looks fine. Good to go!

Thanks for the help @rlaiola

@rlaiola
Copy link
Contributor

rlaiola commented Oct 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants