-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix date check crash #217
base: development
Are you sure you want to change the base?
Conversation
@KPMGE instead of
This and other fixes were proposed in #215 |
Just to keep track, a few changes have been proposed in KPMGE#21 |
Fix date with empty string and handle invalid date format during execution
Thanks for the suggestions @rlaiola |
Tested and everything looks fine. Good to go! |
Thanks for the help @rlaiola |
To test it visit https://rlaiola.github.io/relax/calc/local/uibk/local/6 |
The date check, implemented on #201 was causing a crash when a conversion to data was being performed. That happens because when a field of type date is referenced there's no string args to check, which causes an exception trying to access undefined.
In this PR i also fix the ValueExprFunction typescript types. There were missing types related to a new implementation of reverse, replace, repeat, rlike and regexp.
The error was:
Now it works: