Add Etotal in mwh; Add extra checks for temperature

README.md

@@ -1,12 +1,6 @@
-
-<p align="center">
-    <img src="https://github.com/homebridge/branding/raw/master/logos/homebridge-wordmark-logo-vertical.png" width="150">
-</p>
-
-
 # Homebridge GoodWe Inverter
 
-This homebridge plugin consumes the local broadcasted status by GoodWe Inverters.
+This homebridge plugin consumes the local broadcasted status by GoodWe Inverters on port 8899 (UDP).
 
 ## Setup Development Environment
 

config.schema.json

@@ -52,7 +52,13 @@
         "default": true
       },
       "showDayTotal": {
-        "title": "Show total Day generation (Watt)",
+        "title": "Show total Day generation (Watt hour)",
+        "type": "boolean",
+        "required": true,
+        "default": true
+      },
+      "showTotal": {
+        "title": "Show total generation (Mega Watt hour)",
         "type": "boolean",
         "required": true,
         "default": true

src/platform.ts

@@ -125,10 +125,11 @@ export class HomebridgeGoodWeInverter implements DynamicPlatformPlugin {
 
   parseInverter(output) {
     this.log.debug('parseInverter:output', output);
-    const ret = { internalTemperature: 0, mode: '', generationToday: 0, power: 0 };
+
+    const ret = { internalTemperature: -1, mode: '', generationToday: -1, power: -1, generationTotal: -1 };
     const temperatureIndex = 174;
     const temperature = Number('0x' + output.substring(temperatureIndex, temperatureIndex + 4)) / 10;
-    if(temperature && temperature > 0) {
+    if(temperature && temperature < 80 && temperature > -20) {
       ret.internalTemperature = temperature;
     }
 
@@ -160,6 +161,13 @@ export class HomebridgeGoodWeInverter implements DynamicPlatformPlugin {
       ret.power = power;
     }
 
+    const generationTotalIndex = 190;
+    const generationTotal = Number('0x' + output.substring(generationTotalIndex, generationTotalIndex + 8)) / 10000;
+    if (generationTotal > 0) {
+      ret.generationTotal = generationTotal;
+    }
+
+
     return ret;
   }
 
@@ -170,17 +178,21 @@ export class HomebridgeGoodWeInverter implements DynamicPlatformPlugin {
       const inverterData = await this.lookupLocalInstance(localInstanceConfig);
       if(this.config.showCurrentPowerLevel) {
         accessories.push(
-          this.loadElectricityAccessory(localInstanceConfig, inverterData, ['power'], 'Current Production W'));
+          this.loadElectricityAccessory(localInstanceConfig, inverterData, ['power'], 'Generation Watt'));
       }
       if(this.config.showDayTotal) {
         accessories.push(
-          this.loadElectricityAccessory(localInstanceConfig, inverterData, ['generationToday'], 'Day Production Wh'));
+          this.loadElectricityAccessory(localInstanceConfig, inverterData, ['generationToday'], 'Day Generation Wh'));
       }
       if(this.config.showInternalTemperature) {
         accessories.push(
-          this.loadTemperatureAccessory(localInstanceConfig, inverterData, ['internalTemperature'], 'Internal Temp C'));
+          this.loadTemperatureAccessory(localInstanceConfig, inverterData, ['internalTemperature'], 'Internal Temperature'));
+      }
+      if(this.config.showTotal) {
+        accessories.push(
+          this.loadElectricityAccessory(localInstanceConfig, inverterData, ['generationTotal'], 'Total Generation MWh'));
       }
-      this.fetchLocalInstanceUpdate(10000, localInstanceConfig, accessories);
+      this.fetchLocalInstanceUpdate(localInstanceConfig.timeout + 500, localInstanceConfig, accessories);
     }
   }
 
@@ -189,6 +201,7 @@ export class HomebridgeGoodWeInverter implements DynamicPlatformPlugin {
       const inverterData = await this.lookupLocalInstance(localInstanceConfig);
       this.log.debug(`fetchPowerStationUpdate local-instance: ${localInstanceConfig.localIp}:${localInstanceConfig.port} ` +
         `with # ${accessories.length} accessories`);
+      this.log.debug('inverterData', inverterData);
       for(const accessory of accessories) {
         accessory.update(inverterData);
       }