Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the greeting app that uses guestbook to demos #170

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Add the greeting app that uses guestbook to demos #170

merged 9 commits into from
Aug 6, 2024

Conversation

apoliakov
Copy link
Member

The last link in the doc points to github... why not.

@apoliakov apoliakov changed the title Add the greeting guestbook app to demos Add the greeting app that uses guestbook to demos Aug 1, 2024
kraftp
kraftp reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@kraftp kraftp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove greeting_emails, which is now obsolete.

qianl15
qianl15 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@qianl15 qianl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! The PR looks good to me now.

@apoliakov apoliakov merged commit 5bfd4a2 into main Aug 6, 2024
2 checks passed
@apoliakov apoliakov deleted the greeting-guestbook branch August 6, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftp kraftp kraftp left review comments

@qianl15 qianl15 qianl15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apoliakov @kraftp @qianl15