Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank: use operon package #42

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Bank: use operon package #42

merged 4 commits into from
Sep 26, 2023

Conversation

qianl15
Copy link
Member

@qianl15 qianl15 commented Sep 26, 2023

This PR removes the npm link to Operon and changes to use the private Github package.

One observation: I have to run npm i --save-dev @types/pg in bank backend so the linter doesn't complain about types. I wonder if we should include this dependency directly in Operon?

@qianl15 qianl15 marked this pull request as ready for review September 26, 2023 18:35
@qianl15 qianl15 requested a review from a team September 26, 2023 18:46
@qianl15 qianl15 merged commit 78be616 into main Sep 26, 2023
2 checks passed
@qianl15 qianl15 deleted the qian/bank-operon-package branch September 26, 2023 20:09
@@ -15,6 +15,7 @@
"license": "ISC",
"private": true,
"dependencies": {
"@dbos-inc/operon": "^0.0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't protect you from breaking changes unless we get careful with the 2nd digit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants