Skip to content

Commit

Permalink
nits + lint
Browse files Browse the repository at this point in the history
  • Loading branch information
maxdml committed Jan 31, 2025
1 parent 14881dd commit 36588be
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions src/dbos-executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1598,12 +1598,11 @@ export class DBOSExecutor implements DBOSExecutorContext {
// If this is a serialization failure, i.e., some other DBOS process is trying to re-enqueue or complete the workflow, skip it.
if (this.userDatabase.isRetriableTransactionError(e)) {
this.logger.warn(`Failed to re-enqueue workflow ${pendingWorkflow.workflowUUID}: ${(e as Error).message}`);
continue;
} else {
throw new DBOSWorkflowRecoveryError(pendingWorkflow.workflowUUID, (e as Error).message);
}
continue;
}
continue;
} else {
pendingWorkflows.push(pendingWorkflow.workflowUUID);
}
Expand Down
3 changes: 1 addition & 2 deletions tests/wfqueue.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
} from "../src/debugpoint";
import { DBOSConflictingWorkflowError } from "../src/error";


const queue = new WorkflowQueue("testQ");
const serialqueue = new WorkflowQueue("serialQ", 1);
const serialqueueLimited = new WorkflowQueue("serialQL", { concurrency: 1, rateLimit: { limitPerPeriod: 10, periodSec: 1 } });
Expand Down Expand Up @@ -449,7 +448,7 @@ describe("queued-wf-tests-recovery", () => {
expect((await wfh3.getStatus())?.status).toBe(StatusString.ENQUEUED);

// Unblock the two first workflows
await TestWFs.blockedWorkflowResolve?.();
TestWFs.blockedWorkflowResolve?.();
expect(await wfh1.getResult()).toBe(null);
expect(await wfh2.getResult()).toBe(null);
// Now the third workflow should have been dequeeud and complete
Expand Down

0 comments on commit 36588be

Please sign in to comment.