added logging feature (#8)

src/Contiva.SAP.NWRfc.Abstractions/ILogger.cs

@@ -0,0 +1,20 @@
+using System;
+
+namespace Contiva.SAP.NWRfc
+{
+    public interface ILogger
+    {
+        void LogException(Exception exception, string message);
+        void LogException(Exception exception);
+        void LogTrace(string message, object data);
+        void LogError(string message, object data);
+
+        void LogDebug(string message, object data);
+
+        void LogTrace(string message);
+        void LogDebug(string message);
+        void LogError(string message);
+
+
+    }
+}

src/Contiva.SAP.NWRfc.Abstractions/IRfcRuntime.cs

@@ -44,5 +44,6 @@ public interface IRfcRuntime
         Either<RfcErrorInfo, Unit> SetTimeString(IDataContainerHandle containerHandle, string name, string value);
         Either<RfcErrorInfo, string> GetTimeString(IDataContainerHandle containerHandle, string name);
 
+        Option<ILogger> Logger { get; }
     }
 }

src/Contiva.SAP.NWRfc.Core/Connection.cs

@@ -19,8 +19,6 @@ public Connection(
             _stateAgent = Agent.Start<IConnectionHandle, AgentMessage, Either<RfcErrorInfo, object>>(
                 connectionHandle, (handle, msg) =>
                 {
-                    Console.WriteLine($"Agent: {System.Threading.Thread.CurrentThread.ManagedThreadId}");
-
                     if (handle == null)
                         return (null,
                             new RfcErrorInfo(RfcRc.RFC_INVALID_HANDLE, RfcErrorGroup.EXTERNAL_RUNTIME_FAILURE,
@@ -64,7 +62,7 @@ public Connection(
                     }
                     catch (Exception ex)
                     {
-                        Console.WriteLine(ex);
+                        rfcRuntime.Logger.IfSome(l => l.LogException(ex));
                     }
 
                     throw new InvalidOperationException();
@@ -76,6 +74,7 @@ public static Task<Either<RfcErrorInfo,IConnection>> Create(IDictionary<string,
             return runtime.OpenConnection(connectionParams).Map(handle => (IConnection) new Connection(handle, runtime)).AsTask();
         }
 
+
         public Task<Either<RfcErrorInfo, Unit>> CommitAndWait()
         {
             return CreateFunction("BAPI_TRANSACTION_COMMIT")

src/Contiva.SAP.NWRfc.Native.clr/HandleWrappers.h

@@ -1,4 +1,7 @@
 #pragma once
+#include <sstream> //for std::stringstream 
+#include <string>  //for std::string
+
 
 using namespace System;
 
@@ -48,6 +51,17 @@ namespace Contiva {
 
 				protected:
 					virtual void DestroyHandle(T handle) abstract;
+
+				public:
+					virtual String^ ToString() override
+					{
+						const void * address = static_cast<const void*>(Handle);
+						std::stringstream ss;
+						ss << address;
+						std::string name = ss.str();
+
+						return gcnew String(name.c_str());
+					}
 				};
 
 				template<typename T>

test/SAPSystemTests/Program.cs

@@ -29,7 +29,7 @@ static async Task Main(string[] args)
 
             };
 
-            var runtime = new RfcRuntime();
+            var runtime = new RfcRuntime(new SimpleConsoleLogger());
 
             Task<Either<RfcErrorInfo, IConnection>> ConnFunc() => Connection.Create(settings, runtime);
 

test/SAPSystemTests/SimpleConsoleLogger.cs

@@ -0,0 +1,97 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using Contiva.SAP.NWRfc;
+using Newtonsoft.Json;
+
+namespace SAPSystemTests
+{
+    public class SimpleConsoleLogger : ILogger
+    {
+        public void LogException(Exception exception, string message)
+        {
+            Console.WriteLine($"{message} - Exception: {exception}");
+        }
+
+        public void LogException(Exception exception)
+        {
+            LogException(exception, "");
+        }
+
+        public void LogTrace(string message, object data)
+        {
+            Console.WriteLine($"TRACE\t{message}{ObjectToString(data)}");
+        }
+
+        public void LogError(string message, object data)
+        {
+            Console.WriteLine($"ERROR\t{message}{ObjectToString(data)}");
+        }
+
+        public void LogDebug(string message, object data)
+        {
+            Console.WriteLine($"DEBUG\t{message}{ObjectToString(data)}");
+        }
+
+        public void LogTrace(string message)
+        {
+            LogTrace(message, null);
+        }
+
+        public void LogDebug(string message)
+        {
+            LogDebug(message, null);
+        }
+
+        public void LogError(string message)
+        {
+            LogError(message, null);
+        }
+
+        public static string ObjectToString(object valueObject)
+        {
+            var dataString = new StringBuilder();
+            if (valueObject == null)
+                return "";
+
+            dataString.Append(", Data: ");
+
+            dataString.Append(JsonConvert.SerializeObject(valueObject, new JsonSerializerSettings
+            {
+                Converters = new List<JsonConverter>(new[]{new HandleToStringJsonConverter() })
+            }));
+
+            return dataString.ToString();
+
+        }
+
+        class HandleToStringJsonConverter : JsonConverter
+        {
+            public override bool CanConvert(Type objectType)
+            {
+                if(objectType.BaseType  != null 
+                   && objectType.BaseType.FullName != null 
+                   && (objectType.BaseType.FullName.StartsWith("Contiva.SAP.NWRfc.Native.HandleBase") 
+                   || objectType.BaseType.FullName.StartsWith("Contiva.SAP.NWRfc.Native.DataContainerBase")))
+                    return true;
+                return false;
+            }
+
+            public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
+            {
+                var typeName = value.GetType().Name;                
+                writer.WriteValue($"{typeName}<{value}>");
+            }
+
+            public override bool CanRead
+            {
+                get { return false; }
+            }
+
+            public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
+            {
+                throw new NotImplementedException();
+            }
+        }
+    }
+}