Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snapshot Merge Query #385

Merged
merged 11 commits into from
Jan 6, 2025
Merged

Fix Snapshot Merge Query #385

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3c2f01f
Fix an issue with the snapshot merge query affecting several adapters…
peterallenwebb Dec 17, 2024
0237724
Add changelog entry.
peterallenwebb Dec 17, 2024
2163952
Wrap queries in begin/end block for better Snowflake compatibility.
peterallenwebb Dec 18, 2024
e0a786b
Ensure new 'deletion' records get a new scd_id
peterallenwebb Dec 19, 2024
55dda7e
Revert original fix which is no longer needed. Add a slightly-paranoi…
peterallenwebb Dec 19, 2024
e9e9bb5
Add newline at end of file. :|
peterallenwebb Dec 19, 2024
e7a6932
Reformat code for black.
peterallenwebb Dec 19, 2024
7cbb2c8
Merge branch 'main' into paw/fix-new-record
peterallenwebb Dec 19, 2024
9396281
Merge remote-tracking branch 'origin/main' into paw/fix-new-record
peterallenwebb Dec 20, 2024
878a538
Merge remote-tracking branch 'origin/main' into paw/fix-new-record
peterallenwebb Dec 24, 2024
b150a11
Remove unused macros.
peterallenwebb Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20241217-163126.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix the snapshot merge query for several adapters in new_record mode.
time: 2024-12-17T16:31:26.970526-05:00
custom:
Author: peterallenwebb
Issue: "385"
2 changes: 1 addition & 1 deletion dbt/include/global_project/macros/materializations/snapshots/snapshot_merge.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

merge into {{ target.render() }} as DBT_INTERNAL_DEST
using {{ source }} as DBT_INTERNAL_SOURCE
on DBT_INTERNAL_SOURCE.{{ columns.dbt_scd_id }} = DBT_INTERNAL_DEST.{{ columns.dbt_scd_id }}
on DBT_INTERNAL_SOURCE.{{ columns.dbt_scd_id }} = DBT_INTERNAL_DEST.{{ columns.dbt_scd_id }} and DBT_INTERNAL_SOURCE.dbt_change_type != 'insert'
adrianburusdbt marked this conversation as resolved.
Show resolved Hide resolved

when matched
{% if config.get("dbt_valid_to_current") %}
Expand Down
Loading