Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy first] move exception import to top of functions.py #115

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

MichelleArk
Copy link
Collaborator

@MichelleArk MichelleArk commented Apr 22, 2024

resolves #N/A

Description

The necessity to import this exception dynamically was caused by circular dependencies which have been untangled as part of dbt-labs/dbt-core#8917. This should no longer cause a circular dependency!

Checklist

@MichelleArk MichelleArk requested a review from a team as a code owner April 22, 2024 20:36
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (87a7cc5) to head (d6255df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   56.26%   56.26%           
=======================================
  Files          50       50           
  Lines        3082     3082           
=======================================
  Hits         1734     1734           
  Misses       1348     1348           
Flag Coverage Δ
unit 56.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Apr 23, 2024
@MichelleArk MichelleArk added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 753c03f Apr 23, 2024
18 checks passed
@MichelleArk MichelleArk deleted the tidy/move-exception-import-to-top branch April 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file tidy_first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants