Support using the measure label when using create_metric option (#10536)

.changes/unreleased/Fixes-20240806-172110.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: Propagate measure label when using create_metrics
+time: 2024-08-06T17:21:10.265494-07:00
+custom:
+    Author: aliceliu
+    Issue: "10536"

core/dbt/parser/schema_yaml_readers.py

@@ -612,7 +612,7 @@ def _create_metric(
     ) -> None:
         unparsed_metric = UnparsedMetric(
             name=measure.name,
-            label=measure.name,
+            label=measure.label or measure.name,
             type="simple",
             type_params=UnparsedMetricTypeParams(measure=measure.name, expr=measure.name),
             description=measure.description or f"Metric created from measure {measure.name}",

tests/functional/semantic_models/fixtures.py

@@ -240,6 +240,12 @@
         agg: sum
         agg_time_dimension: ds
         create_metric: true
+      - name: txn_revenue_with_label
+        label: "Transaction Revenue with label"
+        expr: revenue
+        agg: sum
+        agg_time_dimension: ds
+        create_metric: true
       - name: sum_of_things
         expr: 2
         agg: sum

tests/functional/semantic_models/test_semantic_model_parsing.py

@@ -38,11 +38,14 @@ def test_semantic_model_parsing(self, project):
             semantic_model.node_relation.relation_name
             == f'"dbt"."{project.test_schema}"."fct_revenue"'
         )
-        assert len(semantic_model.measures) == 6
-        # manifest should have one metric (that was created from a measure)
-        assert len(manifest.metrics) == 2
+        assert len(semantic_model.measures) == 7
+        # manifest should have two metrics created from measures
+        assert len(manifest.metrics) == 3
         metric = manifest.metrics["metric.test.txn_revenue"]
         assert metric.name == "txn_revenue"
+        metric_with_label = manifest.metrics["metric.test.txn_revenue_with_label"]
+        assert metric_with_label.name == "txn_revenue_with_label"
+        assert metric_with_label.label == "Transaction Revenue with label"
 
     def test_semantic_model_error(self, project):
         # Next, modify the default schema.yml to remove the semantic model.
@@ -107,6 +110,7 @@ def test_semantic_model_deleted_partial_parsing(self, project):
 
     def test_semantic_model_flipping_create_metric_partial_parsing(self, project):
         generated_metric = "metric.test.txn_revenue"
+        generated_metric_with_label = "metric.test.txn_revenue_with_label"
         # First, use the default schema.yml to define our semantic model, and
         # run the dbt parse command
         write_file(schema_yml, project.project_root, "models", "schema.yml")
@@ -117,6 +121,11 @@ def test_semantic_model_flipping_create_metric_partial_parsing(self, project):
         # Verify the metric created by `create_metric: true` exists
         metric = result.result.metrics[generated_metric]
         assert metric.name == "txn_revenue"
+        assert metric.label == "txn_revenue"
+
+        metric_with_label = result.result.metrics[generated_metric_with_label]
+        assert metric_with_label.name == "txn_revenue_with_label"
+        assert metric_with_label.label == "Transaction Revenue with label"
 
         # --- Next, modify the default schema.yml to have no `create_metric: true` ---
         no_create_metric_schema_yml = schema_yml.replace(