Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecesary fire_event_if_test #9522

Merged
merged 3 commits into from
Feb 7, 2024
Merged

remove unnecesary fire_event_if_test #9522

merged 3 commits into from
Feb 7, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 6, 2024

resolves #

Problem

All log lines generated with fire_event_if_test are never used.

Solution

Remove them.

Note: This also should include a change to dbt-common to remove the fire_event_if_test function: dbt-labs/dbt-common#65

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Feb 6, 2024
@emmyoop emmyoop added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15dcb9a) 87.88% compared to head (acf95c1) 87.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9522   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files         167      167           
  Lines       22172    22159   -13     
=======================================
- Hits        19485    19474   -11     
+ Misses       2687     2685    -2     
Flag Coverage Δ
integration 85.45% <ø> (+<0.01%) ⬆️
unit 61.85% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cla-bot cla-bot bot added the cla:yes label Feb 6, 2024
@emmyoop emmyoop marked this pull request as ready for review February 6, 2024 17:00
@emmyoop emmyoop requested a review from a team as a code owner February 6, 2024 17:00
@emmyoop emmyoop merged commit 1220fdf into main Feb 7, 2024
51 checks passed
@emmyoop emmyoop deleted the er/test-events branch February 7, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants