Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy first] Add "Flags" to args parameters in tasks #9856

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Apr 4, 2024

Add Flags type to args parameters in tasks

@gshank gshank added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Apr 4, 2024
@gshank gshank requested a review from a team as a code owner April 4, 2024 21:00
@cla-bot cla-bot bot added the cla:yes label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (a994ace) to head (8fee7ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9856      +/-   ##
==========================================
- Coverage   88.12%   88.12%   -0.01%     
==========================================
  Files         178      178              
  Lines       22459    22457       -2     
==========================================
- Hits        19793    19791       -2     
  Misses       2666     2666              
Flag Coverage Δ
integration 85.56% <100.00%> (-0.02%) ⬇️
unit 61.90% <89.47%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM!

@gshank gshank merged commit b945d17 into main Apr 5, 2024
62 checks passed
@gshank gshank deleted the task_args_type branch April 5, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants