Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dark mode doc #6810

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Updated dark mode doc #6810

merged 10 commits into from
Jan 22, 2025

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Jan 22, 2025

What are you changing in this pull request and why?

I've created this PR following some additional feedback on a PR I created for dark mode (aka theme switching PR: #6776)

I've done the following:

  • Made a small change to the title name: Change your dbt Cloud theme
  • Updated the side bar menu
  • Updated the img in the front matter
  • Updated the link in the release notes so that users are directed to the correct page
  • Updated a link that directs users to Change themes in dbt Cloud

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner January 22, 2025 11:55
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 22, 2025 7:04pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jan 22, 2025
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , one small sugg that's a non blocker.

the main suggestion is that you need to add a redirect to the website/vercel.json file so that users that have the old link (https://docs.getdbt.com/docs/cloud/about-cloud/dark-mode are redirected to the new link (https://docs.getdbt.com/docs/cloud/about-cloud/change-your-dbt-cloud-theme)

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nataliefiann nataliefiann merged commit cfc8ff2 into current Jan 22, 2025
8 checks passed
@nataliefiann nataliefiann deleted the nfiann-changethemes branch January 22, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants