-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dark mode doc #6810
Updated dark mode doc #6810
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @nataliefiann , one small sugg that's a non blocker.
the main suggestion is that you need to add a redirect to the website/vercel.json file so that users that have the old link (https://docs.getdbt.com/docs/cloud/about-cloud/dark-mode
are redirected to the new link (https://docs.getdbt.com/docs/cloud/about-cloud/change-your-dbt-cloud-theme
)
Co-authored-by: Mirna Wong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
What are you changing in this pull request and why?
I've created this PR following some additional feedback on a PR I created for dark mode (aka theme switching PR: #6776)
I've done the following:
Checklist
🚀 Deployment available! Here are the direct links to the updated files: