Add greater support in scroll_into_view
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nearest and center scrolling, as well as support for behavior option
dbuenzli
reviewed
Feb 27, 2025
src/brr.mli
Outdated
| {- with [`Start] (default) the top of the element is align with to to the | ||
| top of the scrollable area.} | ||
| {- with [`End] the bottom of the element is aligned with the bottom of the | ||
| scrollable area.}} |
There was a problem hiding this comment.
Could you please add a description for the new enumerants.
dbuenzli
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends bindings to
scroll_into_viewto support a few more options: