Fix CI for newer PHP versions #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern PHPUnit does not run suites without names.
jtojnar
force-pushed
the
ci-fix
branch
2 times, most recently
from
15714a1 to
5c25715
Compare
PHPUnit 7 is not compatible with PHP 8 and PHPUnit 8 adds return annotations to setUp method, requiring us to add those as well to pass return covariance checks. We can bypass that by renaming the setUp methods and using @before annotations but then there are other issues as well. For example, recent PHPUnit no longer supports @expectexception annotations an other issues. Let’s use Symfony’s PHPUnit bridge, which will allow us the widest range of supported PHP versions. We will need to bump to PHP 5.6+ since that is what php-unit bridge requires but PHP 5.4 is not even supported by Debian Jessie (oldoldstable). We also need to set locale appropriately for the null passed to iconv to work, since phpunit-bridge uses C locale (ASCII) for consistency.
These are relevant now. Also had to explicitly set xdebug mode on versions using XDebug 3.
For easier running of scripts. Now we can just execute `composer test`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.