Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update test workflow inline with other official addons #26

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

tyler36
Copy link
Contributor

@tyler36 tyler36 commented Mar 14, 2024

This PR does the following:

  • Use official DDEV workflow action
  • Standardize the test file format
    • rename file
    • follow current layout conventions

@seebeen seebeen self-assigned this Apr 22, 2024
@seebeen
Copy link
Collaborator

seebeen commented Apr 22, 2024

Looks good! 💪💪💪💪

Can you edit your commit messages to follow the semantic commit format. Angular convention.
If you're not sure how that should look - here is a short crash course

@tyler36 tyler36 force-pushed the 20240314_use_official_workflow_action branch from 1cd347b to b0bde3f Compare April 22, 2024 23:54
@tyler36 tyler36 changed the title Standardize test workflow refactor: update test workflow inline with other official addons Apr 22, 2024
@tyler36
Copy link
Contributor Author

tyler36 commented Apr 22, 2024

Update commit messages as requested.

@tyler36 tyler36 force-pushed the 20240314_use_official_workflow_action branch from b0bde3f to edc1887 Compare April 23, 2024 00:11
@tyler36 tyler36 force-pushed the 20240314_use_official_workflow_action branch from edc1887 to 1f1bdb4 Compare April 23, 2024 00:12
@seebeen
Copy link
Collaborator

seebeen commented Apr 24, 2024

Awesome possum

@seebeen seebeen added this pull request to the merge queue Apr 24, 2024
Merged via the queue into ddev:master with commit f3be6ad Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants