fix: use dynamic ports for router and mailpit, fixes #23

[zeshanziya]

The Issue

Issue #23

How This PR Solves The Issue

Updated the docker-compose.varnish.yaml file to use environment variables (DDEV_ROUTER_HTTPS_PORT and DDEV_ROUTER_HTTP_PORT) for dynamic port configuration.
This change ensures compatibility with custom DDEV port settings and resolves issues when default ports are unavailable

Manual Testing Instructions

ddev config --router-http-port 8080 --router-https-port 8443 --mailpit-http-port 18025 --mailpit-https-port 18026
ddev add-on get https://github.com/zeshanziya/ddev-varnish/tarball/dynamic-router-ports
ddev restart

And look inside:

cat .ddev/.ddev-docker-compose-full.yaml

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[stasadev]

Thank you @zeshanziya !

Yes, that's the right approach, and while we're here, let's update the Mailpit ports too.

DDEV template for the web container has the same env variables https://github.com/ddev/ddev/blob/db18c34739faecd597fbdbb36c6ad743a82e8c45/pkg/ddevapp/app_compose_template.yaml#L203-L208

[rfay]

This PR would be massively better if it had a test for this situation...

[stasadev]

A new test should be added to tests/test.bats

Basically, it should be a copy-paste "install from directory" with the addition of:

@test "install from directory with nonstandard port" {
  set -eu -o pipefail
  cd ${TESTDIR}
  ddev config --router-http-port 8080 --router-https-port 8443 --mailpit-http-port 18025 --mailpit-https-port 18026
  ...
  # change ports here in curl calls
}

And the check should be done for other ports in the test itself instead of the standard ones.

[zeshanziya]

@stasadev Thank you for the guidance. I have updated the Mailpit ports as suggested and added a test case for non-standard ports. Please review.

[stasadev]

Looks great and the new test works, thank you!