Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically configure xhprof for xhgui, remove configuration requirements, fixes #33, fixes #30 #48

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

rfay
Copy link
Member

@rfay rfay commented Jan 2, 2025

The Issue

How This PR Solves The Issue

  • Install perftools/php-profiler globally using custom Dockerfile
  • Load the profiler using the xhprof_prepend.php override
  • Update the README to remove the configuration requirements

Manual Testing Instructions

Install with

ddev add-on get https://github.com/rfay/ddev-xhgui/tarball/20250102_autoconfig_php_profiler

Try it out in several environments.

The new rendered readme is at https://github.com/ddev/ddev-xhgui/blob/196d4a9de5ea4e42d0b8ea8d337cd48cb572e9d2/README.md

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay rfay marked this pull request as ready for review January 2, 2025 20:33
@rfay rfay requested review from tyler36 and stasadev January 2, 2025 20:33
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it using a custom PHP project, and with simple Laravel, it worked for me.
And I noticed a small problem with the working_dir.

config.xhgui.yaml Outdated Show resolved Hide resolved
config.xhgui.yaml Outdated Show resolved Hide resolved
config.xhgui.yaml Outdated Show resolved Hide resolved
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rfay rfay force-pushed the 20250102_autoconfig_php_profiler branch from 19187d3 to e7ef8fe Compare January 6, 2025 01:49
@rfay
Copy link
Member Author

rfay commented Jan 6, 2025

Rebased.

@tyler36
Copy link
Collaborator

tyler36 commented Jan 6, 2025

Great work!

Tested on:

  • Laravel 11
  • Drupal 11
  • CakePHP 5

@tyler36 tyler36 merged commit 9a58a96 into ddev:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants