-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add different i18n path structure #7400
base: main
Are you sure you want to change the base?
Conversation
Hello @martinjagodic, or whoever can answer this for us: Is there any kind of timeline we can expect for this PR to be reviewed? Asking because we need to get the url structure working for our site and are facing deadlines. The answer for what we can expect here will help us decide where we should allocate our development resources accordingly. Thank you in advance! |
@offscriptdev sorry, there is no timeline. We review PRs when we find the time. Currently we have some other PRs in the pipeline to merge, so I can't promise you anything. If you really need this to happen, you can reach out to [email protected] and we can discuss this as a priority. |
Thanks @martinjagodic for your quick reply. It's very helpful. |
I tried to deploy this myself, and got as far as building the JS for the front-end. Saving the content works as expected with all files being saved in the correct location. However, on refresh, the content disappears from the UI. I tracked this down to the folder argument passed into I'll see what I can do about patching all the other implementations a little later. |
…oot for query to server
I've got the UI fetching the content from Gtihub and the local server without issues. I can get a screen recording of my tests if needed, as I didn't see any automated tests covering this. I'd test other implementations, like Gitlab, but I'm frankly way too busy. Recent changes from this repo have been merged into my fork. |
Summary
We have an overall i18n path strategy to place the locale just after the root, and decap does not support this out of the box. To fix this, we added a new structure to i18n.ts.
Basically, Decap supports this site.com/content/locale/slug
But we needed it to support this site.com/locale/content/slug
Test plan
npm run test && npm run format are passing

...
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)

If you don't approve this PR, Piper will be sad.
Do it for Piper :)