Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prop to actions #111

Merged
merged 21 commits into from
May 9, 2024
Merged

feat: Add prop to actions #111

merged 21 commits into from
May 9, 2024

Conversation

cyaiox
Copy link
Collaborator

@cyaiox cyaiox commented May 1, 2024

This PR adds the config component to the game smart items.

Copy link

github-actions bot commented May 2, 2024

Test this pull request

  • The package can be tested by running
    npm i "https://sdk-team-cdn.decentraland.org/@dcl/asset-packs/branch/feat/health-items-simplified-view/dcl-asset-packs-1.17.2-9022241106.commit-aa020ce.tgz"

Remember, if new assets are added in the PR, they won't be avaliable on the CDN until it gets merged. So this can be used to test changes on the package's JS or the catalog.json, but won't work to test newly added items.

@cyaiox cyaiox marked this pull request as ready for review May 6, 2024 15:51
@cazala
Copy link
Contributor

cazala commented May 8, 2024

Just a heads up about the approach of uploading the npm package on the PR: If new assets are added in the PR, they won't be avaliable on the CDN until it gets merged. So this can be used to test changes on the package's JS or the catalog.json, but won't work to test newly added items. It's still quite useful to be able to test those changes before merging though, so I think we should move forward with this.

@cyaiox cyaiox merged commit 3709206 into main May 9, 2024
3 checks passed
@cyaiox cyaiox deleted the feat/health-items-simplified-view branch May 9, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants