Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add avatar components to primary player #100

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Nov 20, 2023

Now avatar components (PlayerIdentityData, AvatarBase, AvatarEquippedData) to Player Entity. It follows the ADR 245

@codecov-commenter
Copy link

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (9a9512b) 13.15% compared to head (6fb7e25) 13.11%.
Report is 1 commits behind head on main.

Files Patch % Lines
...decentraland-godot-lib/src/avatars/avatar_scene.rs 0.00% 48 Missing ⚠️
...aland-godot-lib/src/comms/communication_manager.rs 0.00% 1 Missing ⚠️
rust/decentraland-godot-lib/src/comms/livekit.rs 0.00% 1 Missing ⚠️
rust/decentraland-godot-lib/src/comms/ws_room.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   13.15%   13.11%   -0.05%     
==========================================
  Files         106      106              
  Lines       13010    13053      +43     
==========================================
  Hits         1712     1712              
- Misses      11298    11341      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza merged commit 57a30cd into main Nov 20, 2023
@leanmendoza leanmendoza deleted the fix/add-primary-player-to-adr245 branch November 20, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants