Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new promises #88

Merged
merged 1 commit into from
Nov 10, 2023
Merged

refactor: use new promises #88

merged 1 commit into from
Nov 10, 2023

Conversation

kuruk-mm
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (900bcf1) 14.62% compared to head (a7d1d2a) 14.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   14.62%   14.62%           
=======================================
  Files          98       98           
  Lines       11648    11648           
=======================================
  Hits         1703     1703           
  Misses       9945     9945           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm force-pushed the refactor/use-new-promises branch from c0126b3 to a7d1d2a Compare November 10, 2023 21:43
@kuruk-mm kuruk-mm requested a review from leanmendoza November 10, 2023 21:43
Copy link
Collaborator

@leanmendoza leanmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, change the utils folder with something more descriptive (maybe async, promises)

@kuruk-mm
Copy link
Member Author

LGTM, change the utils folder with something more descriptive (maybe async, promises)

I would prefer to let the folder at it's. When I get the Asset approved in the Godot Asset Library, I'm going to add it as an addon.

Util folder can be useful for other usages.

@kuruk-mm kuruk-mm merged commit 030d930 into main Nov 10, 2023
3 checks passed
@kuruk-mm kuruk-mm deleted the refactor/use-new-promises branch November 10, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants