Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pointer position and drag #1052

Draft
wants to merge 7 commits into
base: protocol-squad
Choose a base branch
from

Conversation

robtfm
Copy link

@robtfm robtfm commented Jan 17, 2025

  • add PET_DRAG, PET_DRAG_LOCKED, PET_DRAG_END PointerEventTypes
  • add PBPointerInfo message

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/pointer-position-and-drag/dcl-sdk-7.7.2-12838488074.commit-6247bed.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/pointer-position-and-drag/dcl-sdk-commands-7.7.2-12838488074.commit-6247bed.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/pointer-position-and-drag/@dcl/inspector/dcl-inspector-7.7.2-12838488074.commit-6247bed.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/pointer-position-and-drag-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/pointer-position-and-drag

Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2025

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: a1197f6
Status: ✅  Deploy successful!
Preview URL: https://a050666f.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-pointer-position-and-dr.js-sdk-toolchain.pages.dev

View logs

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 55.93220% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (protocol-squad@ea9e109). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/@dcl/ecs/src/systems/events.ts 48.78% 21 Missing ⚠️
packages/@dcl/react-ecs/src/reconciler/index.ts 64.28% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             protocol-squad    #1052   +/-   ##
=================================================
  Coverage                  ?   70.77%           
=================================================
  Files                     ?      160           
  Lines                     ?     5468           
  Branches                  ?     1006           
=================================================
  Hits                      ?     3870           
  Misses                    ?     1456           
  Partials                  ?      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants