-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Smart Wearables #1952
Merged
Merged
feat: Smart Wearables #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyaiox
force-pushed
the
feat/smart-wearables
branch
from
July 27, 2023 14:32
efdd11a
to
08b3b04
Compare
cyaiox
force-pushed
the
feat/smart-wearables
branch
from
July 28, 2023 21:09
912721c
to
02446aa
Compare
cyaiox
force-pushed
the
feat/smart-wearables
branch
from
August 7, 2023 17:26
cbaa0a2
to
3de1250
Compare
* feat: Show smart badge instead of only icon in the Asset Card * fix: Display animation on smart badge only on hover * fix: Send corret asset type to the smart badge * styles: Add missing EOL * chore: Bump UI with the change of the smart icon
…n detail page (#1934) * feat: Add required permissions in the SW item detail page * feat: Make the asset image container flexible enough to adapt to the new stats in the right side * feat: Add button to play sw video showcase * test: Fix tests of the new modal * refactor: Generalize required permissions to reuse it in the wearable detail * feat: Saga to fetch the required permissions * feat: Wait the required permissions before loading the assets * feat: Fetch req permissions when they are not yet loaded in the state * feat: Render video using the data from the catalyst * test: Missing tests related to the video and req permissions fetching and components * styles: Sort imports
* feat: Give OnlySmart filter more visibility * chore: Add TODO * style: Fix styles reviewed in the PR * feat: Show different sections depending on the dispositive
* feat: Fetch item content to take the video from builder api * fix: Use asset itemid only * fix: Visual fixes in the showcase modal * feat: Add EOL in css file
* feat: Add smart wearables ftu modal (#1928) * feat: Add smart wearables ftu modal * chore: Change CTA wording * feat: Add ftu video and fix styles * fix: PR Feedback * chore: Smart wearables related wording * test: Fix test that was not using translations * fix: Keep FTU video border and increase its height * fix: Add preload auto in the ftu video * feat: SW FTU Learn More redirects to the new blogpost
cyaiox
force-pushed
the
feat/smart-wearables
branch
from
August 9, 2023 14:13
7a8f535
to
781ab01
Compare
kevinszuchet
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an integration branch for the Smart Wearables feature.