Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce logic to fetch catalog from the marketplace-server #1967

Merged
merged 11 commits into from
Nov 8, 2023

Conversation

juanmahidalgo
Copy link
Contributor

@juanmahidalgo juanmahidalgo commented Aug 10, 2023

This PR enables the marketplace-server as the catalog provider based on its feature flag status.

"PEER_URL": "https://peer-ue-2.decentraland.zone",
"SIGNATURES_SERVER_URL": "https://signatures-api.decentraland.zone/v1",
"MARKETPLACE_FAVORITES_SERVER_URL": "https://marketplace-favorites-api.decentraland.zone/v1",
"NETWORK": "mainnet",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes will be rollbacked before merging

Copy link
Contributor

@kevinszuchet kevinszuchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments. LGTM 🚀

@coveralls
Copy link

coveralls commented Sep 22, 2023

Coverage Status

coverage: 40.778% (+0.04%) from 40.739%
when pulling 2fce441 on feat/marketplace-server-catalog
into 6c7d8ea on master.

@juanmahidalgo juanmahidalgo merged commit 14f47d9 into master Nov 8, 2023
6 checks passed
@juanmahidalgo juanmahidalgo deleted the feat/marketplace-server-catalog branch November 8, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants