-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce logic to fetch catalog from the marketplace-server #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmahidalgo
requested review from
kevinszuchet,
LautaroPetaccio and
cyaiox
and removed request for
kevinszuchet and
LautaroPetaccio
August 11, 2023 07:34
juanmahidalgo
commented
Aug 11, 2023
webapp/src/config/env/dev.json
Outdated
"PEER_URL": "https://peer-ue-2.decentraland.zone", | ||
"SIGNATURES_SERVER_URL": "https://signatures-api.decentraland.zone/v1", | ||
"MARKETPLACE_FAVORITES_SERVER_URL": "https://marketplace-favorites-api.decentraland.zone/v1", | ||
"NETWORK": "mainnet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes will be rollbacked before merging
kevinszuchet
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments. LGTM 🚀
juanmahidalgo
force-pushed
the
feat/marketplace-server-catalog
branch
from
September 22, 2023 09:09
8392277
to
56f4423
Compare
juanmahidalgo
force-pushed
the
feat/marketplace-server-catalog
branch
from
October 16, 2023 09:49
56f4423
to
906747d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the marketplace-server as the catalog provider based on its feature flag status.