fix: error while downloading camera reel #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New build in progress, come back later! |
lorenzo-ranciaffi
added
force-build
AnsisMalins
approved these changes
Feb 17, 2025
github-actions
bot
requested review from
dalkia,
Ludmilafantaniella and
popuz
Ludmilafantaniella
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Approved! ✅
Tested on Windows and Mac. The reel downloads successfully without errors, and the file is correctly saved in the expected folder:
⭐ ${user-home}/decentraland/reels.
3087-fix.mp4
Notes from the discussion in the thread:
- Currently, there is no default download folder, as its location is arbitrary.
- On Mac, the file should be found in
/Users/{name-of-user}/decentraland/reels. - The goal of this PR is to fix the error message and ensure users can download files without issues.
- A future improvement could be to either save the file in the Downloads folder or inform users where to find it.
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- ✔️ Log In/Log Out
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Camera
- ✔️ Skybox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fixes #3081
Remove the opening of the system folder where the file has been downloaded (there is no support for
System.Diagnostic.ProcessAPI as stated here, at the very last point)How to test the changes?
${user-home}/decentraland/reelsOur Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md