-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic lights #3113
Merged
Merged
feat: dynamic lights #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
This was referenced Jan 13, 2025
…b to addressables
…o avoid being computed as TextureMove tweens.
# Conflicts: # Explorer/Assets/AddressableAssetsData/AssetGroups/Essentials.asset # Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportCategory.cs # Explorer/Assets/DCL/SDKComponents/Tween/Systems/TweenUpdaterSystem.cs # scripts/package-lock.json # scripts/package.json
AnsisMalins
requested changes
Jan 27, 2025
Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportCategory.cs
Show resolved
Hide resolved
Explorer/Assets/DCL/SDKComponents/LightSource/Systems/LightSourceSystem.cs
Outdated
Show resolved
Hide resolved
…rt for protocol default values. Added support for shadow mask. Improved LightSource System architecture making it cleaner.
# Conflicts: # Explorer/Assets/AddressableAssetsData/AssetGroups/Essentials.asset # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef # Explorer/Assets/DCL/RealmNavigation/Container/RealmNavigationContainer.cs.meta # Explorer/Assets/Protocol/DecentralandProtocol/LightSource.gen.cs.meta # Explorer/Assets/Protocol/DecentralandProtocol/SocialServiceV3.gen.cs.meta # scripts/package-lock.json # scripts/package.json
DafGreco
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lights checked on both platforms ! ✅
Windows check : ✅
03.02.2025_08.07.24_REC.mp4
Sanity check made on Windows :
- Chat interactions
- Skybox functionality
- Emotes
- Teleport ( Dollhouse , the inn and metadynelabs)
- Map
- Camera functionality
- Gallery
Macos check ✅
Sanity check made on macos :
- Backpack
- Emotes
- Teleport (Dollhouse, the inn , metadynelabs)
- Camera functionality
- Gallery
- Notifications
- Skybox functionality
AnsisMalins
approved these changes
Feb 3, 2025
# Conflicts: # Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportCategory.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Protocol PR: decentraland/protocol#234
SDK PR: decentraland/js-sdk-toolchain#1049
QA TEST STEPS
npm i
and thennpm run start
RedGreen cube
The cornell-boxes
DarkRoom
Hard shadow:
![](https://private-user-images.githubusercontent.com/163010988/408811929-85a432f3-71d4-4b8d-b1d4-8a1c4557852c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTA4NTQsIm5iZiI6MTczODk1MDU1NCwicGF0aCI6Ii8xNjMwMTA5ODgvNDA4ODExOTI5LTg1YTQzMmYzLTcxZDQtNGI4ZC1iMWQ0LThhMWM0NTU3ODUyYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QxNzQ5MTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MTM4OWFkMjYxZTg5YWNhNjZjZDFhMWFmNzNkZDAxMmExMjIzYmE5OTQxZDhjNTgxNDkyODVlZmVhMzJlOTJmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Tu4IvK3WvaaaWjOyCUT9EqLviVMPA39QL96-e7KzGrs)
Soft shadow:
![](https://private-user-images.githubusercontent.com/163010988/408811970-ae5bc465-3c8d-4ded-801e-206c06abe5cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTA4NTQsIm5iZiI6MTczODk1MDU1NCwicGF0aCI6Ii8xNjMwMTA5ODgvNDA4ODExOTcwLWFlNWJjNDY1LTNjOGQtNGRlZC04MDFlLTIwNmMwNmFiZTVjYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QxNzQ5MTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01Y2Y1MjQ2YzBjMmM2ZTJkY2ExZjZkYTdhOWIzMGExNDAwZTZjMWE2NWQ0NmE5M2Y0NDY2ZTRlYjM4Njk1ZTZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.66DlN6vPkKzvfq4gVM7l8kXoBtcw34rxo595Hxbsj_c)
The Stage
Disclaimer: Some tooltips might have typos or might not get properly updated, that's a scene code bug not related to Dynamic Lights 😅