Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print system information on startup. #3348

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Conversation

m3taphysics
Copy link
Collaborator

Pull Request Description

What does this PR change?

It prints full device information to Player.log

image

Test Instructions

  1. Run explorer
  2. Verify that Player.log contains the device information

Quality Checklist

  • Changes have been tested locally
  • Performance impact has been considered

Code Review Reference

Please review our Code Review Standards before submitting.

@m3taphysics m3taphysics requested review from a team as code owners February 12, 2025 16:42
@m3taphysics m3taphysics changed the title Print system information on startup. chore: print system information on startup. Feb 12, 2025
Copy link
Collaborator

@aixaCode aixaCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, but lgtm

Explorer/Assets/Scripts/Global/Dynamic/MainSceneLoader.cs Outdated Show resolved Hide resolved
Signed-off-by: Ashley Canning <[email protected]>
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by QA ✅

Tested and confirmed that the system information is correctly printed in Player.log on startup.

windows-Logs

image

Everything is working as expected. ✅

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [ x] Log In/Log Out
  • [x ] Backpack and wearables in world
  • [ x] Emotes in world and in backpack
  • [x ] Teleport with map/coordinates/Jump In
  • [ x] Chat and multiplayer
  • [x ] Profile card
  • [x ] Camera
  • [x ] Skybox
  • [ x] Settings

@m3taphysics m3taphysics enabled auto-merge (squash) February 13, 2025 15:20
@m3taphysics m3taphysics merged commit a757239 into dev Feb 14, 2025
5 checks passed
@m3taphysics m3taphysics deleted the chore/print-system-utils branch February 14, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants