Implement changes for SDLC - CI pipeline and PR template #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update vitest.config.js with coverage settings and JSX transformation - Configure CI workflow to create coverage directories - Set initial coverage thresholds to 0 for gradual improvement - Add Code Climate test reporter integration The changes ensure proper test coverage reporting both locally and in CI, with Code Climate integration for tracking coverage metrics.
⛔ Snyk checks have failed. 1 issues have been found so far.
⛔ security/snyk check is complete. 1 issues have been found. (View Details) |
timler
reviewed
Dec 12, 2024
.github/workflows/ci.yml
Outdated
| NODE_VERSION: '16' | ||
|
|
||
| jobs: | ||
| continuous-integration: |
There was a problem hiding this comment.
I think we should align our workflows - please change this to "test" to match the job on npm "test:coverage", and then change the name of the file to continuous-integration.yml
There was a problem hiding this comment.
Thank you @timler I have updated my PR
.github/workflows/ci.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
I forgot to add this for my pipeline, so will do that!
added 2 commits
December 12, 2024 12:05
- Rename workflow file to continuous-integration.yml - Update job name to test to match npm script (test:coverage) - Add pull request template for standardization
- Update the folder structrure for the pull request template
timler
reviewed
Dec 12, 2024
| - '**.md' | ||
| - 'docs/**' | ||
| - '.gitignore' | ||
| - 'LICENSE' |
There was a problem hiding this comment.
This is what I added - AFAIK you don't need separate definition for pull_request because it's covered under push
on:
push:
paths-ignore:
- '**.md'
- '**.txt'
- '**.json'
- '**.yml'
- '**.properties'
- '**.xml'
- '**.sql'
- '**.csv'
- '**.zip'
- 'docs/**'
- '.gitignore'
There was a problem hiding this comment.
It makes sense, let me resolve that
- Update paths-ignore to ensure critical files trigger builds - Maintain focus on push events, the pull request trigger is redundant
Moved the PR template from the folder into the main .github folder so the template is applied by default and doesn't need a query parameter
timler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: