Include the scheme in presented URLs. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping service assumes that presented URLs are full URLs, while the docs (and the presenter) constructed them omitting the scheme. Even though the scheme is irrelevant for mapping, I think I'd rather keep something called a "presented URL" an actual URL.
smashwilson
added a commit
that referenced
this pull request
Mar 25, 2015
Include the scheme in presented URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping service assumes that presented URLs are full URLs, while the
docs (and the presenter) constructed them omitting the scheme. Even though
the scheme is irrelevant for mapping, I think I'd rather keep something
called a "presented URL" an actual URL.