Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an alternative way to pass parameters #30
Implement an alternative way to pass parameters #30
Changes from 7 commits
3e9c796
e89956d
56e2ecd
6dc318b
2f12b74
b86a5fa
be05405
d673c4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be weird with nested mod folders like
arma3server/server_mods/my_favourite_ones/@asp
. Better to look inside@asp
folder i.e. just one parent_path to also avoid bloating the arma server folder. Will also work better with server providers that symlinks the mod folders together into a temp folder.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getSharedObjectPath returns path like
arma3server/server_mods/my_favourite_ones/@asp/intercept/asp.dll
one parent is intercept/ folder, second parent is @asp/ folder
So this should be correct I'd think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it returns the full path to the plugin. To get the ASP folder we need to back out of file and the intercept directory. Yeah, it is a little cleaner to use the parent_path function rather than adding the "go up path" string and having to make the path normalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefix error with
ASP failed to read JSON config:
or something to differentiate from other (Intercept) extensions that might be logging JSON errorsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already prefixed. This line will be printed immediately after "ASP: Found a Configuration File" line. Good enough for me