Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHC Python Breaking Time and RollingWAvg Change #159

Closed
stanbrub opened this issue Sep 5, 2023 · 0 comments · Fixed by #160
Closed

DHC Python Breaking Time and RollingWAvg Change #159

stanbrub opened this issue Sep 5, 2023 · 0 comments · Fixed by #160
Assignees
Labels
bug Something isn't working

Comments

@stanbrub
Copy link
Collaborator

stanbrub commented Sep 5, 2023

A recent merge has changed how DH python references "now" for current time. Also, rolling_wavg_tick/time has changed the weight_col name to wcol.

  • JoinTablesFromParquetAndStreamTest: Removing the import altogether should just use the java version
  • DateTimeFormulaTest: Looks like the Java version of 'now' was already being used. Check it anyway
  • In the event the Python version really is needed, do the below
  • Update the rolling_wavg_tick and time benchmarks (Get rid of the weight_col param altogether?)

Was:

from deephaven.time import now
print('Time', now())

Change to:

from deephaven.time import dh_now
print('Time', dh_now())
@stanbrub stanbrub added the bug Something isn't working label Sep 5, 2023
@stanbrub stanbrub self-assigned this Sep 5, 2023
@stanbrub stanbrub changed the title DHC Python Breaking Time Change DHC Python Breaking Time and RollingWAvg Change Sep 5, 2023
@stanbrub stanbrub linked a pull request Sep 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant